I would like to know your opinion of Roy's future in the meta.
I think that Roy is kind of overrated. I do think that he's been the best that he's been in a smash game. However, he still has that reverse tipper mechanic. It forces him to put himself in more danger than most other of the sword characters. I hate when I get a forward smash and get a sour spot that hits like a wooden stick. Is there any reason to use Roy over any of the sword characters like Marth, Lucina, and Chrom? Especially when they have better spacing abilities.
Roy's sourspots are more of an annoyance than an actual problem. A good Roy should be able to extend his advantage regardless of whether he hits the sweetspot or sourspot. They do, however, matter for killing, which can make them a problem in certain matchups; for example, Pichu and Inkling can be really hard to hit with sweetspots thanks to their low profiles. An argument could be made that it also hurts vs swordies, who can actually outspace his sweetspots, but Roy has the mobility to whiff-punish most of them, not to mention how well they all edgeguard Chrom which makes it less clear-cut which one should be used.
There are also matchups which are clearly better for Roy. Mario, for example, can gimp Chrom for free with smart use of Fludd, whereas Roy can still recover against him. Squirtle's a very similar case.
In all, I don't really see Roy being pushed out of the meta anytime soon. He's got nearly the same matchup spread as Chrom, being better in some places and worse in others, and he has a good number of top-level representatives right now, especially now that Sethlon and Hyper are back out of retirement.
Their only real notable weakness were their difficulty to KO. They had decent mobility, frame data, and combo game.
See, here's the thing: they really didn't. Their ground mobility was okay, but nothing spectacular, and their air mobility was really bad, having a lower airspeed than Palutena without even sharing her great air acceleration to make up for it. Their frame data wasn't great, either. They had no ground buttons that came out before frame 5, and outside of their frame 4 Nair, none of their aerials came out before frame 10. In terms of endlag, they had no safe ground moves except maybe the back hit of Dsmash (even that was -6 on drop, which is still punishable), and all of their aerials had at least 20 frames of landing lag. As far as combos go, their throw combos were decent, but nothing really special. They rarely got much more than 20% off a neutral win, which isn't exactly great. They also had next to no combo starters, with dthrow and nair being the only ones of note.
Their disadvantage was also pretty exploitable. Multiple jumps allowed them to stall in the air and offstage, but they didn't really have safe options to land with, and their recovery was linear and lacked a hitbox. I still maintain that the Pits were one of the most overrated characters on the final tier list. They should've landed solidly in low tier, but because no one knew or knows anything about them, they stayed in the middle of the pack.
Their gameplay wasn't about landing with aerials, but approaching on the ground, which they can do well.
Sure, but here's the thing: A bunch of characters could approach on the ground as well as or better than them, and got more reward off of it.
If the struggle to KO was a big liability, then why is Sheik top 5 in the game?
First of all, the Pits struggled to kill more than Sheik. Sheik had no reliable kill confirms or safe kill options, but she had plenty of strings and 50/50s into the kill moves she did have, like Uair, Vanish, and Bouncing Fish. The Pits had Bair, which was unsafe and required a tipper to kill; Ftilt, which was unsafe and required a tipper to kill (Dark Pit didn't even get that one); Fsmash, which was unsafe and had a habit of failing to connect properly; Usmash, which was unsafe and had a habit of whiffing on grounded opponents; Dsmash, which was unsafe on the front hit, usually unsafe on the back hit, and didn't even kill that well; Electroshock if you were Dark Pit, which was slow and unsafe; and Fthrow, which was pretty much their only reliable kill option and didn't even kill till ~150.
Second of all, Sheik had way more other stuff going for her, like the best frame data in the game, great mobility, great shield dash, needles, a great combo game, good edgeguarding, good ledgetrapping, and basically anything you could ever want except high damage moves and safe kill options. Even with all of that, people still disputed her top 5 position because of her struggles to kill and lack of postpatch results relative to other top tiers.