Thank goodness this isn't an essay or anything
If spamming is a crime, will Olimar be exiled from Smash? The guy NEEDS Pikmin spam.
But besides things like that, it depends. If you're in a competitive scene, do what you need to do for the monies. Spam, edgehog, pick Metaknight, whatever. But in friendlies, YOU might be having fun, but if others aren't they probably won't play you again.
Coming from the other side, I don't spam. I use Bowser and ZSS, so it's impossible. And facing spammers, Bowser is freaking big and freaking slow, so he's gonna get hit. ZSS has a stupid high short hop and generally the most awkward approach I've seen since I mained Mewtwo in Melee. So spamming is really effective on me due to my choice of characters. And due to Stale Move Negation, the main danger of spamming is to the mind (sans Diddy's bananas). It's frustrating, but that's because such a simple tactic is giving your opponent the edge over you. So it's just something you need to work around. You'll feel better after you close the gap and smash your opponent in the face (in game, i mean).
It's just another tactic that you'll find annoying or devoid of any class whatsoever. Personally, when I use Bowser I have a complete and utter disregard for petty things like damage. ZSS I still have a problem with, because she's getting hurt and she doesn't have a big spiky shell to protect her. When all else fails, I used to use G&W for Oil Panic and maneuverability, but now I just use DK because Spiking is the solution to EVERYTHING.