Yes, I agree that if Camelot's next project is for Ninty's next hardware, then it is less likely to be Golden Sun and more likely to be Mario sports again.I don't want to catastrophize, but if Nintendo's next thing releases by next year, it's not inconceivable they may just start the Tennis/Golf loop again and release one of those maybe in 2024.
I certainly hope not. This next Camelot game could go either way, system-wise. But whatever it is, if it releases for the Switch after the new system is out, I worry about how well it will perform. If it's Mario something, that wouldn't really be a big deal, Mario will always continue. If it's Golden Sun... that'd be really disadvantageous timing for a series that... isn't inherently an assured success. And has already had its fair share of bad timing.
Ideally it would be Golden Sun, and release within the successor's launch window, giving it that boost (which GS1 also probably benefitted from). That would still give them time for Tennis and Golf within that system's lifespan. And there's probably already going to be both another Mario Kart and high-profile Mario platformer (probably from the Odyssey team) coming close to launch on that thing (especially since they won't have a launch Zelda) given both those teams have clearly been working on something for a while, so yet another Mario wouldn't exactly be needed.
And I agree that having GS at the end of the Switch's lifecycle again could be bad for its sales. However, I feel getting it towards the end of the Switch era might be the only way to get it, in which case I will easily take it over nothing.
Other than the more dream-like scenario of getting brand-new GS as a launch game on the next hardware, the next-best thing for the series I feel is for the Switch to hang on through 2024/2025, leaving ample room for a new GS (say in 2024) to take advantage of that install base before they head off to presumably greener pastures. IMO rooting for the Switch to last a little longer and for us to get GS on Switch in like 2024 is kind of a middle ground between the fantasy of GS being a launch game and the doom-and-gloom of a new GS being DOA due to launching in the Switch's twilight.